Commit ad94dc3a authored Apr 03, 2019 by Andrea Righi Committed by Juergen Gross Apr 05, 2019

xen: use struct_size() helper in kzalloc()



struct privcmd_buf_vma_private has a zero-sized array at the end
(pages), use the new struct_size() helper to determine the proper
allocation size and avoid potential type mistakes.

Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>

parent 0266def9

drivers/xen/privcmd-buf.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -140,8 +140,7 @@ static int privcmd_buf_mmap(struct file file, struct vm_area_struct vma)
		if (!(vma->vm_flags & VM_SHARED))
		return -EINVAL;

		vma_priv = kzalloc(sizeof(vma_priv) + count sizeof(void *),
		GFP_KERNEL);
		vma_priv = kzalloc(struct_size(vma_priv, pages, count), GFP_KERNEL);
		if (!vma_priv)
		return -ENOMEM;

Admin message