Commit ad6fef77 authored Feb 12, 2019 by Greg Kroah-Hartman Committed by Anna Schumaker Feb 12, 2019

rpc: properly check debugfs dentry before using it



debugfs can now report an error code if something went wrong instead of
just NULL.  So if the return value is to be used as a "real" dentry, it
needs to be checked if it is an error before dereferencing it.

This is now happening because of ff9fb72b ("debugfs: return error
values, not NULL"), but why debugfs files are not being created properly
is an older issue, probably one that has always been there and should
probably be looked at...

Cc: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Jeff Layton <jlayton@kernel.org>
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>
Cc: Anna Schumaker <anna.schumaker@netapp.com>
Cc: linux-nfs@vger.kernel.org
Cc: netdev@vger.kernel.org
Reported-by: David Howells <dhowells@redhat.com>
Tested-by: David Howells <dhowells@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

parent a4cb5bdb

net/sunrpc/debugfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -146,7 +146,7 @@ rpc_clnt_debugfs_register(struct rpc_clnt *clnt)
		rcu_read_lock();
		xprt = rcu_dereference(clnt->cl_xprt);
		/* no "debugfs" dentry? Don't bother with the symlink. */
		if (!xprt->debugfs) {
		if (IS_ERR_OR_NULL(xprt->debugfs)) {
		rcu_read_unlock();
		return;
		}

Admin message