Commit ad6cca6d authored Apr 26, 2010 by Dan Carpenter Committed by Steve French Apr 26, 2010

cifs: change && to ||



This is a typo, if pvolume_info were NULL it would oops.

This function is used in clean up and error handling.  The current code
never passes a NULL pvolume_info, but it could pass a NULL *pvolume_info
if the kmalloc() failed.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>

parent 04912d6a

fs/cifs/connect.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2421,7 +2421,7 @@ cleanup_volume_info(struct smb_vol **pvolume_info)
		{
		struct smb_vol *volume_info;

		if (!pvolume_info && !*pvolume_info)
		if (!pvolume_info \|\| !*pvolume_info)
		return;

		volume_info = *pvolume_info;

Admin message