Commit ad516907 authored Feb 09, 2018 by Chris Wilson

drm/i915: Move the final intel_gpu_reset() to after declaring wedged

If we fail to reset the GPU (i915_reset()), we do one final
intel_gpu_reset() attempt as we mark the device wedged. The idea here is
even though the GPU has proven unreliable (and so we want to stop using
it for the time being), we don't want it spinning away in the background
whilst the driver idles so we try to reset it one more time. However, we
want to dump the i915_gem_set_wedged() debugging info before we do, so
that we can see the accurate state of the GPU when it failed.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180209114056.9957-1-chris@chris-wilson.co.uk

parent 0f550a21

drivers/gpu/drm/i915/i915_drv.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1920,7 +1920,6 @@ void i915_reset(struct drm_i915_private *i915, unsigned int flags)
		ret = i915_gem_reset_prepare(i915);
		if (ret) {
		dev_err(i915->drm.dev, "GPU recovery failed\n");
		intel_gpu_reset(i915, ALL_ENGINES);
		goto taint;
		}

		@@ -2003,6 +2002,7 @@ taint:
		error:
		i915_gem_set_wedged(i915);
		i915_gem_retire_requests(i915);
		intel_gpu_reset(i915, ALL_ENGINES);
		goto finish;
		}

Admin message