Commit ad473db4 authored Mar 17, 2020 by Pierre-Louis Bossart Committed by Vinod Koul Mar 19, 2020

soundwire: cadence: remove automatic command retries

This is a good idea on paper, but it's not recommended at all when
operating in multi-master mode. It's also not recommended when doing
bank switches, since the retransmission would happen at the next SSP,
and the command protocol is stuck in the mean time.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200317163329.25501-15-pierre-louis.bossart@linux.intel.com

Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 91080111

drivers/soundwire/cadence_master.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1109,8 +1109,7 @@ int sdw_cdns_init(struct sdw_cdns *cdns)

		/* leave frame delay to hardware default of 0x1F */

		/* Set Max cmd retry to 15 */
		val \|= CDNS_MCP_CONFIG_MCMD_RETRY;
		/* leave command retry to hardware default of 0 */

		cdns_writel(cdns, CDNS_MCP_CONFIG, val);