Commit ad1e46a8 authored by Soheil Hassas Yeganeh's avatar Soheil Hassas Yeganeh Committed by David S. Miller
Browse files

ipv6: process socket-level control messages in IPv6 



Process socket-level control messages by invoking
__sock_cmsg_send in ip6_datagram_send_ctl for control messages on
the SOL_SOCKET layer.

This makes sure whenever ip6_datagram_send_ctl is called for
udp and raw, we also process socket-level control messages.

This is a bit uglier than IPv4, since IPv6 does not have
something like ipcm_cookie. Perhaps we can later create
a control message cookie for IPv6?

Note that this commit interprets new control messages that
were ignored before. As such, this commit does not change
the behavior of IPv6 control messages.

Signed-off-by: default avatarSoheil Hassas Yeganeh <soheil@google.com>
Acked-by: default avatarWillem de Bruijn <willemb@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 24025c46

include/net/transp_v6.h

+2 −1
Original line number Diff line number Diff line
@@ -42,7 +42,8 @@ void ip6_datagram_recv_specific_ctl(struct sock *sk, struct msghdr *msg, 


int ip6_datagram_send_ctl(struct net *net, struct sock *sk, struct msghdr *msg,

			  struct flowi6 *fl6, struct ipv6_txoptions *opt,

			  int *hlimit, int *tclass, int *dontfrag);

			  int *hlimit, int *tclass, int *dontfrag,

			  struct sockcm_cookie *sockc);



void ip6_dgram_sock_seq_show(struct seq_file *seq, struct sock *sp,

			     __u16 srcp, __u16 destp, int bucket);

net/ipv6/datagram.c

+8 −1
Original line number Diff line number Diff line
@@ -685,7 +685,8 @@ EXPORT_SYMBOL_GPL(ip6_datagram_recv_ctl); 
int ip6_datagram_send_ctl(struct net *net, struct sock *sk,

			  struct msghdr *msg, struct flowi6 *fl6,

			  struct ipv6_txoptions *opt,

			  int *hlimit, int *tclass, int *dontfrag)

			  int *hlimit, int *tclass, int *dontfrag,

			  struct sockcm_cookie *sockc)

{

	struct in6_pktinfo *src_info;

	struct cmsghdr *cmsg;
@@ -702,6 +703,12 @@ int ip6_datagram_send_ctl(struct net *net, struct sock *sk, 
			goto exit_f;

		}



		if (cmsg->cmsg_level == SOL_SOCKET) {

			if (__sock_cmsg_send(sk, msg, cmsg, sockc))

				return -EINVAL;

			continue;

		}



		if (cmsg->cmsg_level != SOL_IPV6)

			continue;

net/ipv6/ip6_flowlabel.c

+2 −1
Original line number Diff line number Diff line
@@ -372,6 +372,7 @@ fl_create(struct net *net, struct sock *sk, struct in6_flowlabel_req *freq, 
	if (olen > 0) {

		struct msghdr msg;

		struct flowi6 flowi6;

		struct sockcm_cookie sockc_junk;

		int junk;



		err = -ENOMEM;
@@ -390,7 +391,7 @@ fl_create(struct net *net, struct sock *sk, struct in6_flowlabel_req *freq, 
		memset(&flowi6, 0, sizeof(flowi6));



		err = ip6_datagram_send_ctl(net, sk, &msg, &flowi6, fl->opt,

					    &junk, &junk, &junk);

					    &junk, &junk, &junk, &sockc_junk);

		if (err)

			goto done;

		err = -EINVAL;

net/ipv6/ipv6_sockglue.c

+2 −1
Original line number Diff line number Diff line
@@ -471,6 +471,7 @@ sticky_done: 
		struct ipv6_txoptions *opt = NULL;

		struct msghdr msg;

		struct flowi6 fl6;

		struct sockcm_cookie sockc_junk;

		int junk;



		memset(&fl6, 0, sizeof(fl6));
@@ -503,7 +504,7 @@ sticky_done: 
		msg.msg_control = (void *)(opt+1);



		retv = ip6_datagram_send_ctl(net, sk, &msg, &fl6, opt, &junk,

					     &junk, &junk);

					     &junk, &junk, &sockc_junk);

		if (retv)

			goto done;

update:

net/ipv6/raw.c

+5 −1
Original line number Diff line number Diff line
@@ -745,6 +745,7 @@ static int rawv6_sendmsg(struct sock *sk, struct msghdr *msg, size_t len) 
	struct dst_entry *dst = NULL;

	struct raw6_frag_vec rfv;

	struct flowi6 fl6;

	struct sockcm_cookie sockc;

	int addr_len = msg->msg_namelen;

	int hlimit = -1;

	int tclass = -1;
@@ -821,13 +822,16 @@ static int rawv6_sendmsg(struct sock *sk, struct msghdr *msg, size_t len) 
	if (fl6.flowi6_oif == 0)

		fl6.flowi6_oif = sk->sk_bound_dev_if;



	sockc.tsflags = 0;



	if (msg->msg_controllen) {

		opt = &opt_space;

		memset(opt, 0, sizeof(struct ipv6_txoptions));

		opt->tot_len = sizeof(struct ipv6_txoptions);



		err = ip6_datagram_send_ctl(sock_net(sk), sk, msg, &fl6, opt,

					    &hlimit, &tclass, &dontfrag);

					    &hlimit, &tclass, &dontfrag,

					    &sockc);

		if (err < 0) {

			fl6_sock_release(flowlabel);

			return err;

CRA Git | Maintained and supported by SUSTech CRA and CCSE