selinux: Use kcalloc() in policydb_index() (ad10a105) · Commits · 戴 / test

Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. Signed-off-by:

Markus Elfring <elfring@users.sourceforge.net> Signed-off-by:

Paul Moore <paul@paul-moore.com>

security/selinux/ss/policydb.c

+9 −9

Original line number	Diff line number	Diff line
		@@ -540,22 +540,22 @@ static int policydb_index(struct policydb *p)
		#endif

		rc = -ENOMEM;
		p->class_val_to_struct =
		kzalloc(p->p_classes.nprim * sizeof(*(p->class_val_to_struct)),
		p->class_val_to_struct = kcalloc(p->p_classes.nprim,
		sizeof(*p->class_val_to_struct),
		GFP_KERNEL);
		if (!p->class_val_to_struct)
		goto out;

		rc = -ENOMEM;
		p->role_val_to_struct =
		kzalloc(p->p_roles.nprim * sizeof(*(p->role_val_to_struct)),
		p->role_val_to_struct = kcalloc(p->p_roles.nprim,
		sizeof(*p->role_val_to_struct),
		GFP_KERNEL);
		if (!p->role_val_to_struct)
		goto out;

		rc = -ENOMEM;
		p->user_val_to_struct =
		kzalloc(p->p_users.nprim * sizeof(*(p->user_val_to_struct)),
		p->user_val_to_struct = kcalloc(p->p_users.nprim,
		sizeof(*p->user_val_to_struct),
		GFP_KERNEL);
		if (!p->user_val_to_struct)
		goto out;

Admin message