Commit acfa1823 authored Jun 23, 2005 by Andreas Dilger Committed by Linus Torvalds Jun 23, 2005

[PATCH] Support for dx directories in ext3_get_parent (NFSD)

Henrik Grubbstrom noted:

The 2.6.10 ext3_get_parent attempts to use ext3_find_entry to look up the
entry "..", which fails for dx directories since ".." is not present in the
directory hash table.  The patch below solves this by looking up the dotdot
entry in the dx_root block.

Typical symptoms of the above bug are intermittent claims by nfsd that
files or directories are missing on exported ext3 filesystems.

cf https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=3D150759 and
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=3D144556



ext3_get_parent() is IMHO the wrong place to fix this bug as it introduces
a lot of internals from htree into that function.  Instead, I think this
should be fixed in ext3_find_entry() as in the below patch.  This has the
added advantage that it works for any callers of ext3_find_entry() and not
just ext3_lookup_parent().

Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: Henrik Grubbstrom <grubba@grubba.org>
Cc: <ext2-devel@lists.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent d6e71144

fs/ext3/namei.c

+10 −2

Original line number	Diff line number	Diff line
		@@ -932,8 +932,16 @@ static struct buffer_head * ext3_dx_find_entry(struct dentry *dentry,
		struct inode *dir = dentry->d_parent->d_inode;

		sb = dir->i_sb;
		/* NFS may look up ".." - look at dx_root directory block */
		if (namelen > 2 \|\| name[0] != '.'\|\|(name[1] != '.' && name[1] != '\0')){
		if (!(frame = dx_probe(dentry, NULL, &hinfo, frames, err)))
		return NULL;
		} else {
		frame = frames;
		frame->bh = NULL; /* for dx_release() */
		frame->at = (struct dx_entry )frames; / hack for zero entry*/
		dx_set_block(frame->at, 0); /* dx_root block is 0 */
		}
		hash = hinfo.hash;
		do {
		block = dx_get_block(frame->at);

Admin message