devlink: Introduce devlink port flavour virtual (acf1ee44) · Commits · 戴 / test

Currently mlx5 PCI PF and VF devlink devices register their ports as physical port in non-representors mode. Introduce a new port flavour as virtual so that virtual devices can register 'virtual' flavour to make it more clear to users. An example of one PCI PF and 2 PCI virtual functions, each having one devlink port. $ devlink port show pci/0000:06:00.0/1: type eth netdev ens2f0 flavour physical port 0 pci/0000:06:00.2/1: type eth netdev ens2f2 flavour virtual port 0 pci/0000:06:00.3/1: type eth netdev ens2f3 flavour virtual port 0 Reviewed-by:

Jiri Pirko <jiri@mellanox.com> Signed-off-by:

Parav Pandit <parav@mellanox.com> Acked-by:

Jakub Kicinski <kuba@kernel.org> Signed-off-by:

David S. Miller <davem@davemloft.net>

include/uapi/linux/devlink.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -187,6 +187,7 @@ enum devlink_port_flavour {
		* for the PCI VF. It is an internal
		* port that faces the PCI VF.
		*/
		DEVLINK_PORT_FLAVOUR_VIRTUAL, /* Any virtual port facing the user. */
		};

		enum devlink_param_cmode {

net/core/devlink.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -545,6 +545,7 @@ static int devlink_nl_port_attrs_put(struct sk_buff *msg,
		case DEVLINK_PORT_FLAVOUR_PHYSICAL:
		case DEVLINK_PORT_FLAVOUR_CPU:
		case DEVLINK_PORT_FLAVOUR_DSA:
		case DEVLINK_PORT_FLAVOUR_VIRTUAL:
		if (nla_put_u32(msg, DEVLINK_ATTR_PORT_NUMBER,
		attrs->phys.port_number))
		return -EMSGSIZE;
		@@ -6806,6 +6807,7 @@ static int __devlink_port_phys_port_name_get(struct devlink_port *devlink_port,

		switch (attrs->flavour) {
		case DEVLINK_PORT_FLAVOUR_PHYSICAL:
		case DEVLINK_PORT_FLAVOUR_VIRTUAL:
		if (!attrs->split)
		n = snprintf(name, len, "p%u", attrs->phys.port_number);
		else

Admin message