Commit acd388fd authored by Steven Rostedt (Red Hat)'s avatar Steven Rostedt (Red Hat) Committed by Steven Rostedt
Browse files

tracing: Give system name a pointer 

Normally the compiler will use the same pointer for a string throughout
the file. But there's no guarantee of that happening. Later changes will
require that all events have the same pointer to the system string.

Name the system string and have all events point to it.

Testing this, it did not increases the size of the text, except for the
notes section, which should not harm the real size any.

Link: http://lkml.kernel.org/r/20150403013802.220157513@goodmis.org



Reviewed-by: default avatarMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Tested-by: default avatarMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent 6e9dd8dd

include/linux/ftrace_event.h

+1 −1
Original line number Diff line number Diff line
@@ -202,7 +202,7 @@ enum trace_reg { 
struct ftrace_event_call;



struct ftrace_event_class {

	char			*system;

	const char		*system;

	void			*probe;

#ifdef CONFIG_PERF_EVENTS

	void			*perf_probe;

include/trace/ftrace.h

+17 −2
Original line number Diff line number Diff line
@@ -18,6 +18,21 @@ 


#include <linux/ftrace_event.h>



#ifndef TRACE_SYSTEM_VAR

#define TRACE_SYSTEM_VAR TRACE_SYSTEM

#endif



#define __app__(x, y) str__##x##y

#define __app(x, y) __app__(x, y)



#define TRACE_SYSTEM_STRING __app(TRACE_SYSTEM_VAR,__trace_system_name)



#define TRACE_MAKE_SYSTEM_STR()				\

	static const char TRACE_SYSTEM_STRING[] =	\

		__stringify(TRACE_SYSTEM)



TRACE_MAKE_SYSTEM_STR();



/*

 * DECLARE_EVENT_CLASS can be used to add a generic function

 * handlers for events. That is, if all events have the same
@@ -105,7 +120,6 @@ 


#include TRACE_INCLUDE(TRACE_INCLUDE_FILE)





/*

 * Stage 2 of the trace events.

 *
@@ -692,7 +706,7 @@ static inline void ftrace_test_probe_##call(void) \ 
_TRACE_PERF_PROTO(call, PARAMS(proto));					\

static const char print_fmt_##call[] = print;				\

static struct ftrace_event_class __used __refdata event_class_##call = { \

	.system			= __stringify(TRACE_SYSTEM),		\

	.system			= TRACE_SYSTEM_STRING,			\

	.define_fields		= ftrace_define_fields_##call,		\

	.fields			= LIST_HEAD_INIT(event_class_##call.fields),\

	.raw_init		= trace_event_raw_init,			\
@@ -735,6 +749,7 @@ __attribute__((section("_ftrace_events"))) *__event_##call = &event_##call 


#include TRACE_INCLUDE(TRACE_INCLUDE_FILE)



#undef TRACE_SYSTEM_VAR



#ifdef CONFIG_PERF_EVENTS

CRA Git | Maintained and supported by SUSTech CRA and CCSE