Commit acd1f046 authored Oct 23, 2019 by Chengguang Xu Committed by Jan Kara Oct 24, 2019

ext2: return error when fail to allocating memory in ioctl

Currently, we do not check memory allocation
result for ei->i_block_alloc_info in ioctl,
this patch checks it and returns error in
failure case.

Link: https://lore.kernel.org/r/20191023135643.28837-1-cgxu519@mykernel.net


Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
Signed-off-by: Jan Kara <jack@suse.cz>

parent ba1af2e4

fs/ext2/ioctl.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -145,10 +145,13 @@ setversion_out:
		if (ei->i_block_alloc_info){
		struct ext2_reserve_window_node *rsv = &ei->i_block_alloc_info->rsv_window_node;
		rsv->rsv_goal_size = rsv_window_size;
		} else {
		ret = -ENOMEM;
		}

		mutex_unlock(&ei->truncate_mutex);
		mnt_drop_write_file(filp);
		return 0;
		return ret;
		}
		default:
		return -ENOTTY;

Admin message