Commit acc978d7 authored by tongtiangen's avatar tongtiangen Committed by Rob Clark
Browse files

drm/msm/dpu: Remove some set but not used variables 



Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c: In function _dpu_debugfs_show_regset32:
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c:142:26: warning: variable priv set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c: In function dpu_kms_prepare_commit:
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c:271:21: warning: variable dev set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c: In function _dpu_kms_hw_destroy:
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c:555:21: warning: variable dev set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c: In function dpu_kms_hw_init:
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c:763:26: warning: variable priv set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c: In function dpu_runtime_suspend:
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c:1021:21: warning: variable ddev set but not used [-Wunused-but-set-variable]

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatartongtiangen <tongtiangen@huawei.com>
Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
parent b83caf42

drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c

+0 −16
Original line number Diff line number Diff line
@@ -138,16 +138,12 @@ static int _dpu_debugfs_show_regset32(struct seq_file *s, void *data) 
{

	struct dpu_debugfs_regset32 *regset = s->private;

	struct dpu_kms *dpu_kms = regset->dpu_kms;

	struct drm_device *dev;

	struct msm_drm_private *priv;

	void __iomem *base;

	uint32_t i, addr;



	if (!dpu_kms->mmio)

		return 0;



	dev = dpu_kms->dev;

	priv = dev->dev_private;

	base = dpu_kms->mmio + regset->offset;



	/* insert padding spaces, if needed */
@@ -346,8 +342,6 @@ static ktime_t dpu_kms_vsync_time(struct msm_kms *kms, struct drm_crtc *crtc) 
static void dpu_kms_prepare_commit(struct msm_kms *kms,

		struct drm_atomic_state *state)

{

	struct dpu_kms *dpu_kms;

	struct drm_device *dev;

	struct drm_crtc *crtc;

	struct drm_crtc_state *crtc_state;

	struct drm_encoder *encoder;
@@ -355,8 +349,6 @@ static void dpu_kms_prepare_commit(struct msm_kms *kms, 


	if (!kms)

		return;

	dpu_kms = to_dpu_kms(kms);

	dev = dpu_kms->dev;



	/* Call prepare_commit for all affected encoders */

	for_each_new_crtc_in_state(state, crtc, crtc_state, i) {
@@ -631,11 +623,8 @@ static long dpu_kms_round_pixclk(struct msm_kms *kms, unsigned long rate, 


static void _dpu_kms_hw_destroy(struct dpu_kms *dpu_kms)

{

	struct drm_device *dev;

	int i;



	dev = dpu_kms->dev;



	if (dpu_kms->hw_intr)

		dpu_hw_intr_destroy(dpu_kms->hw_intr);

	dpu_kms->hw_intr = NULL;
@@ -839,7 +828,6 @@ static int dpu_kms_hw_init(struct msm_kms *kms) 
{

	struct dpu_kms *dpu_kms;

	struct drm_device *dev;

	struct msm_drm_private *priv;

	int i, rc = -EINVAL;



	if (!kms) {
@@ -854,8 +842,6 @@ static int dpu_kms_hw_init(struct msm_kms *kms) 
	if (rc)

		return rc;



	priv = dev->dev_private;



	atomic_set(&dpu_kms->bandwidth_ref, 0);



	dpu_kms->mmio = msm_ioremap(dpu_kms->pdev, "mdp", "mdp");
@@ -1102,10 +1088,8 @@ static int __maybe_unused dpu_runtime_suspend(struct device *dev) 
	int rc = -1;

	struct platform_device *pdev = to_platform_device(dev);

	struct dpu_kms *dpu_kms = platform_get_drvdata(pdev);

	struct drm_device *ddev;

	struct dss_module_power *mp = &dpu_kms->mp;



	ddev = dpu_kms->dev;

	rc = msm_dss_enable_clk(mp->clk_config, mp->num_clk, false);

	if (rc)

		DPU_ERROR("clock disable failed rc:%d\n", rc);

CRA Git | Maintained and supported by SUSTech CRA and CCSE