Commit acb921a5 authored Jul 27, 2015 by Vladimir Zapolskiy Committed by Greg Kroah-Hartman Aug 05, 2015

misc: cxl: clean up afu_read_config()



The sanity checks for overflow are not needed, because this is done on
caller side in fs/sysfs/file.c

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Cc: Ian Munsie <imunsie@au1.ibm.com>
Acked-by: Michael Neuling <mikey@neuling.org>
Reviewed-by: Daniel Axtens <dja@axtens.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 594069bc

drivers/misc/cxl/sysfs.c

+1 −6

Original line number	Diff line number	Diff line
		@@ -443,12 +443,7 @@ static ssize_t afu_read_config(struct file filp, struct kobject kobj,
		struct afu_config_record *cr = to_cr(kobj);
		struct cxl_afu *afu = to_cxl_afu(container_of(kobj->parent, struct device, kobj));

		u64 i, j, val, size = afu->crs_len;

		if (off > size)
		return 0;
		if (off + count > size)
		count = size - off;
		u64 i, j, val;

		for (i = 0; i < count;) {
		val = cxl_afu_cr_read64(afu, cr->cr, off & ~0x7);

Admin message