Commit ac9ff799 authored Oct 28, 2013 by Michael wang Committed by Ingo Molnar Oct 28, 2013

sched: Remove extra put_online_cpus() inside sched_setaffinity()



Commit 6acce3ef:

	sched: Remove get_online_cpus() usage

has left one extra put_online_cpus() inside sched_setaffinity(),
remove it to fix the WARN:

   ------------[ cut here ]------------
   WARNING: CPU: 0 PID: 3166 at kernel/cpu.c:84 put_online_cpus+0x43/0x70()
   ...
   [<ffffffff810c3fef>] put_online_cpus+0x43/0x70 [
   [<ffffffff810efd59>] sched_setaffinity+0x7d/0x1f9 [
   ...

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Tested-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Michael Wang <wangyun@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/526DD0EE.1090309@linux.vnet.ibm.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent e9aa39bb

kernel/sched/core.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -3716,7 +3716,6 @@ long sched_setaffinity(pid_t pid, const struct cpumask *in_mask)
		p = find_process_by_pid(pid);
		if (!p) {
		rcu_read_unlock();
		put_online_cpus();
		return -ESRCH;
		}

Admin message