Unverified Commit ac9978fc authored Nov 16, 2020 by Zhihao Cheng Committed by Mark Brown Nov 16, 2020

spi: cadence-quadspi: Fix error return code in cqspi_probe



Fix to return the error code from
devm_reset_control_get_optional_exclusive() instaed of 0
in cqspi_probe().

Fixes: 31fb632b ("spi: Move cadence-quadspi driver to drivers/spi/")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Link: https://lore.kernel.org/r/20201116141836.2970579-1-chengzhihao1@huawei.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent d853b340

drivers/spi/spi-cadence-quadspi.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1260,12 +1260,14 @@ static int cqspi_probe(struct platform_device *pdev)
		/* Obtain QSPI reset control */
		rstc = devm_reset_control_get_optional_exclusive(dev, "qspi");
		if (IS_ERR(rstc)) {
		ret = PTR_ERR(rstc);
		dev_err(dev, "Cannot get QSPI reset.\n");
		goto probe_reset_failed;
		}

		rstc_ocp = devm_reset_control_get_optional_exclusive(dev, "qspi-ocp");
		if (IS_ERR(rstc_ocp)) {
		ret = PTR_ERR(rstc_ocp);
		dev_err(dev, "Cannot get QSPI OCP reset.\n");
		goto probe_reset_failed;
		}

Admin message