Commit ac828456 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

media: atomisp: Fix error code in ov5693_probe() 



If gmin_camera_platform_data() returns NULL then we should return a
negative error instead of success.

Fixes: 90ebe55a ("media: staging: atomisp: Add driver prefix to Kconfig option and module names")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 3d81099c

drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c

+4 −2
Original line number Diff line number Diff line
@@ -1899,7 +1899,7 @@ static int ov5693_probe(struct i2c_client *client) 
{

	struct ov5693_device *dev;

	int i2c;

	int ret = 0;

	int ret;

	void *pdata;

	unsigned int i;
@@ -1929,8 +1929,10 @@ static int ov5693_probe(struct i2c_client *client) 
	pdata = gmin_camera_platform_data(&dev->sd,

					  ATOMISP_INPUT_FORMAT_RAW_10,

					  atomisp_bayer_order_bggr);

	if (!pdata)

	if (!pdata) {

		ret = -EINVAL;

		goto out_free;

	}



	ret = ov5693_s_config(&dev->sd, client->irq, pdata);

	if (ret)

CRA Git | Maintained and supported by SUSTech CRA and CCSE