Commit ac7c992c authored by Thadeu Lima de Souza Cascardo's avatar Thadeu Lima de Souza Cascardo Committed by David S. Miller
Browse files

e100: do not go D3 in shutdown unless system is powering off 



After experimenting with kexec with the last merges after 2.6.29, I've
had some problems when probing e100.  It would not read the eeprom.  After
some bisects, I realized this has been like that since forever (at least
2.6.18).  The problem is that shutdown is doing the same thing that
suspend does and puts the device in D3 state.  I couldn't find a way to
get the device back to a sane state in the probe function.  So, based on
some similar patches from Rafael J. Wysocki for e1000, e1000e, and ixgbe,
I wrote this one for e100.

Signed-off-by: default avatarThadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Acked-by: default avatar"Rafael J. Wysocki" <rjw@sisk.pl>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent bf0de3e9

drivers/net/e100.c

+23 −7
Original line number Diff line number Diff line
@@ -2728,7 +2728,7 @@ static void __devexit e100_remove(struct pci_dev *pdev) 
#define E100_82552_SMARTSPEED   0x14   /* SmartSpeed Ctrl register */

#define E100_82552_REV_ANEG     0x0200 /* Reverse auto-negotiation */

#define E100_82552_ANEG_NOW     0x0400 /* Auto-negotiate now */

static int e100_suspend(struct pci_dev *pdev, pm_message_t state)

static void __e100_shutdown(struct pci_dev *pdev, bool *enable_wake)

{

	struct net_device *netdev = pci_get_drvdata(pdev);

	struct nic *nic = netdev_priv(netdev);
@@ -2749,19 +2749,32 @@ static int e100_suspend(struct pci_dev *pdev, pm_message_t state) 
			           E100_82552_SMARTSPEED, smartspeed |

			           E100_82552_REV_ANEG | E100_82552_ANEG_NOW);

		}

		if (pci_enable_wake(pdev, PCI_D3cold, true))

			pci_enable_wake(pdev, PCI_D3hot, true);

		*enable_wake = true;

	} else {

		pci_enable_wake(pdev, PCI_D3hot, false);

		*enable_wake = false;

	}



	pci_disable_device(pdev);

	pci_set_power_state(pdev, PCI_D3hot);

}



	return 0;

static int __e100_power_off(struct pci_dev *pdev, bool wake)

{

	if (wake) {

		return pci_prepare_to_sleep(pdev);

	} else {

		pci_wake_from_d3(pdev, false);

		return pci_set_power_state(pdev, PCI_D3hot);

	}

}



#ifdef CONFIG_PM

static int e100_suspend(struct pci_dev *pdev, pm_message_t state)

{

	bool wake;

	__e100_shutdown(pdev, &wake);

	return __e100_power_off(pdev, wake);

}



static int e100_resume(struct pci_dev *pdev)

{

	struct net_device *netdev = pci_get_drvdata(pdev);
@@ -2792,7 +2805,10 @@ static int e100_resume(struct pci_dev *pdev) 


static void e100_shutdown(struct pci_dev *pdev)

{

	e100_suspend(pdev, PMSG_SUSPEND);

	bool wake;

	__e100_shutdown(pdev, &wake);

	if (system_state == SYSTEM_POWER_OFF)

		__e100_power_off(pdev, wake);

}



/* ------------------ PCI Error Recovery infrastructure  -------------- */

CRA Git | Maintained and supported by SUSTech CRA and CCSE