Commit ac5d5b3f authored by Lorenzo Bianconi's avatar Lorenzo Bianconi Committed by Kalle Valo
Browse files

mt76: verify evt type in usb mcu response 



Verify if evt field is set to EVT_CMD_DONE in usb mcu
response messages. This is a preliminary patch for usb_mcu layer
unification between mt76x0u and mt76x2u driver.

Signed-off-by: default avatarLorenzo Bianconi <lorenzo.bianconi@redhat.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 9b2fd48d

drivers/net/wireless/mediatek/mt76/dma.h

+10 −0
Original line number Diff line number Diff line
@@ -75,6 +75,16 @@ enum dma_msg_port { 
	DISCARD,

};



enum mt76_mcu_evt_type {

	EVT_CMD_DONE,

	EVT_CMD_ERROR,

	EVT_CMD_RETRY,

	EVT_EVENT_PWR_RSP,

	EVT_EVENT_WOW_RSP,

	EVT_EVENT_CARRIER_DETECT_RSP,

	EVT_EVENT_DFS_DETECT_RSP,

};



int mt76_dma_attach(struct mt76_dev *dev);

void mt76_dma_cleanup(struct mt76_dev *dev);

drivers/net/wireless/mediatek/mt76/usb_mcu.c

+2 −1
Original line number Diff line number Diff line
@@ -73,7 +73,8 @@ static int mt76u_mcu_wait_resp(struct mt76_dev *dev, u8 seq) 
		if (ret)

			return ret;



		if (seq == FIELD_GET(MT_RX_FCE_INFO_CMD_SEQ, rxfce))

		if (seq == FIELD_GET(MT_RX_FCE_INFO_CMD_SEQ, rxfce) &&

		    FIELD_GET(MT_RX_FCE_INFO_EVT_TYPE, rxfce) == EVT_CMD_DONE)

			return 0;



		dev_err(dev->dev, "error: MCU resp evt:%lx seq:%hhx-%lx\n",

CRA Git | Maintained and supported by SUSTech CRA and CCSE