Commit ac47bf5e authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Jason Gunthorpe
Browse files

RDMA/mlx5: Limit the scope of mlx5_ib_enable_driver function 

The mlx5_ib_enable_driver() is local function and doesn't need to be
shared in mlx5_ib, so change it's signature to have static keyword in it.

Link: https://lore.kernel.org/r/20200702081809.423482-2-leon@kernel.org


Reviewed-by: default avatarMaor Gottlieb <maorg@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent cc33b23e

drivers/infiniband/hw/mlx5/main.c

+12 −12
Original line number Diff line number Diff line
@@ -6569,6 +6569,18 @@ static void mlx5_ib_stage_flow_db_cleanup(struct mlx5_ib_dev *dev) 
	kfree(dev->flow_db);

}



static int mlx5_ib_enable_driver(struct ib_device *dev)

{

	struct mlx5_ib_dev *mdev = to_mdev(dev);

	int ret;



	ret = mlx5_ib_test_wc(mdev);

	mlx5_ib_dbg(mdev, "Write-Combining %s",

		    mdev->wc_support ? "supported" : "not supported");



	return ret;

}



static const struct ib_device_ops mlx5_ib_dev_ops = {

	.owner = THIS_MODULE,

	.driver_id = RDMA_DRIVER_MLX5,
@@ -7092,18 +7104,6 @@ static void mlx5_ib_stage_devx_cleanup(struct mlx5_ib_dev *dev) 
	}

}



int mlx5_ib_enable_driver(struct ib_device *dev)

{

	struct mlx5_ib_dev *mdev = to_mdev(dev);

	int ret;



	ret = mlx5_ib_test_wc(mdev);

	mlx5_ib_dbg(mdev, "Write-Combining %s",

		    mdev->wc_support ? "supported" : "not supported");



	return ret;

}



void __mlx5_ib_remove(struct mlx5_ib_dev *dev,

		      const struct mlx5_ib_profile *profile,

		      int stage)

drivers/infiniband/hw/mlx5/mlx5_ib.h

+0 −1
Original line number Diff line number Diff line
@@ -1542,7 +1542,6 @@ static inline bool mlx5_ib_can_use_umr(struct mlx5_ib_dev *dev, 
	return true;

}



int mlx5_ib_enable_driver(struct ib_device *dev);

int mlx5_ib_test_wc(struct mlx5_ib_dev *dev);



static inline bool mlx5_ib_lag_should_assign_affinity(struct mlx5_ib_dev *dev)

CRA Git | Maintained and supported by SUSTech CRA and CCSE