Commit ac452b8e authored Aug 08, 2019 by Bart Van Assche Committed by Martin K. Petersen Aug 12, 2019

scsi: qla2xxx: Fix session lookup in qlt_abort_work()



Pass the correct session ID to find_sess_by_s_id() instead of passing an
uninitialized variable.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Fixes: 2d70c103 ("[SCSI] qla2xxx: Add LLD target-mode infrastructure for >= 24xx series") # v3.5.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Tested-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent f1333c48

drivers/scsi/qla2xxx/qla_target.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -6198,7 +6198,6 @@ static void qlt_abort_work(struct qla_tgt *tgt,
		struct qla_hw_data *ha = vha->hw;
		struct fc_port *sess = NULL;
		unsigned long flags = 0, flags2 = 0;
		uint32_t be_s_id;
		uint8_t s_id[3];
		int rc;

		@@ -6211,8 +6210,7 @@ static void qlt_abort_work(struct qla_tgt *tgt,
		s_id[1] = prm->abts.fcp_hdr_le.s_id[1];
		s_id[2] = prm->abts.fcp_hdr_le.s_id[0];

		sess = ha->tgt.tgt_ops->find_sess_by_s_id(vha,
		(unsigned char *)&be_s_id);
		sess = ha->tgt.tgt_ops->find_sess_by_s_id(vha, s_id);
		if (!sess) {
		spin_unlock_irqrestore(&ha->tgt.sess_lock, flags2);

Admin message