MIPS: Alchemy: Fix memleak in alchemy_clk_setup_cpu (ac3b57ad) · Commits · 戴 / test

If the clk_register fails, we should free h before function returns to prevent memleak. Fixes: ("MIPS: Alchemy: clock framework integration of onchip clocks") Reported-by:

Hulk Robot <hulkci@huawei.com> Signed-off-by:

Zhang Qilong <zhangqilong3@huawei.com> Signed-off-by:

Thomas Bogendoerfer <tsbogend@alpha.franken.de>

arch/mips/alchemy/common/clock.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -152,6 +152,7 @@ static struct clk __init alchemy_clk_setup_cpu(const char parent_name,
		{
		struct clk_init_data id;
		struct clk_hw *h;
		struct clk *clk;

		h = kzalloc(sizeof(*h), GFP_KERNEL);
		if (!h)
		@@ -164,7 +165,13 @@ static struct clk __init alchemy_clk_setup_cpu(const char parent_name,
		id.ops = &alchemy_clkops_cpu;
		h->init = &id;

		return clk_register(NULL, h);
		clk = clk_register(NULL, h);
		if (IS_ERR(clk)) {
		pr_err("failed to register clock\n");
		kfree(h);
		}

		return clk;
		}

		/* AUXPLLs ************************************************************/

Admin message