Commit ac2b0813 authored Sep 10, 2019 by Dan Carpenter Committed by Wolfram Sang Apr 30, 2020

i2c: amd-mp2-pci: Fix Oops in amd_mp2_pci_init() error handling



The problem is that we dereference "privdata->pci_dev" when we print
the error messages in amd_mp2_pci_init():

	dev_err(ndev_dev(privdata), "Failed to enable MP2 PCI device\n");
		^^^^^^^^^^^^^^^^^

Fixes: 529766e0 ("i2c: Add drivers for the AMD PCIe MP2 I2C controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@kernel.org

parent 8839e460

drivers/i2c/busses/i2c-amd-mp2-pci.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -349,12 +349,12 @@ static int amd_mp2_pci_probe(struct pci_dev *pci_dev,
		if (!privdata)
		return -ENOMEM;

		privdata->pci_dev = pci_dev;
		rc = amd_mp2_pci_init(privdata, pci_dev);
		if (rc)
		return rc;

		mutex_init(&privdata->c2p_lock);
		privdata->pci_dev = pci_dev;

		pm_runtime_set_autosuspend_delay(&pci_dev->dev, 1000);
		pm_runtime_use_autosuspend(&pci_dev->dev);

Admin message