Unverified Commit ac0a6899 authored Feb 20, 2020 by Matthias Reichl Committed by Mark Brown Feb 20, 2020

ASoC: pcm512x: Fix unbalanced regulator enable call in probe error path



When we get a clock error during probe we have to call
regulator_bulk_disable before bailing out, otherwise we trigger
a warning in regulator_put.

Fix this by using "goto err" like in the error cases above.

Fixes: 5a3af129 ("ASoC: pcm512x: Add PCM512x driver")
Signed-off-by: Matthias Reichl <hias@horus.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200220202956.29233-1-hias@horus.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 63d68382

sound/soc/codecs/pcm512x.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -1564,13 +1564,15 @@ int pcm512x_probe(struct device dev, struct regmap regmap)
		}

		pcm512x->sclk = devm_clk_get(dev, NULL);
		if (PTR_ERR(pcm512x->sclk) == -EPROBE_DEFER)
		return -EPROBE_DEFER;
		if (PTR_ERR(pcm512x->sclk) == -EPROBE_DEFER) {
		ret = -EPROBE_DEFER;
		goto err;
		}
		if (!IS_ERR(pcm512x->sclk)) {
		ret = clk_prepare_enable(pcm512x->sclk);
		if (ret != 0) {
		dev_err(dev, "Failed to enable SCLK: %d\n", ret);
		return ret;
		goto err;
		}
		}

Admin message