rtc: ds1343: use regmap_update_bits for glitch filter (ac08888b) · Commits · 戴 / test

Use regmap_update_bits to update DS1343_CONTROL_REG in a race free manner when setting the glitch filter. Link: https://lore.kernel.org/r/20191019204941.6203-5-alexandre.belloni@bootlin.com Signed-off-by:

drivers/rtc/rtc-ds1343.c

+8 −10

Original line number	Diff line number	Diff line
		@@ -108,20 +108,18 @@ static ssize_t ds1343_store_glitchfilter(struct device *dev,
		const char *buf, size_t count)
		{
		struct ds1343_priv *priv = dev_get_drvdata(dev->parent);
		int data;

		regmap_read(priv->map, DS1343_CONTROL_REG, &data);
		int data = 0;
		int res;

		if (strncmp(buf, "enabled", 7) == 0)
		data \|= DS1343_EGFIL;

		else if (strncmp(buf, "disabled", 8) == 0)
		data &= ~(DS1343_EGFIL);

		else
		data = DS1343_EGFIL;
		else if (strncmp(buf, "disabled", 8))
		return -EINVAL;

		regmap_write(priv->map, DS1343_CONTROL_REG, data);
		res = regmap_update_bits(priv->map, DS1343_CONTROL_REG,
		DS1343_EGFIL, data);
		if (res)
		return res;

		return count;
		}