hvcs: Ensure page aligned partner info buffer (ac07a4a5) · Commits · 戴 / test

The Power platform requires the partner info buffer to be page aligned otherwise it will fail the partner info hcall with H_PARAMETER. Switch from using kmalloc to allocate this buffer to __get_free_page to ensure page alignment. Signed-off-by:

Brian King <brking@linux.vnet.ibm.com> Signed-off-by:

Benjamin Herrenschmidt <benh@kernel.crashing.org>

drivers/tty/hvc/hvcs.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1532,7 +1532,7 @@ static int __devinit hvcs_initialize(void)
		goto register_fail;
		}

		hvcs_pi_buff = kmalloc(PAGE_SIZE, GFP_KERNEL);
		hvcs_pi_buff = (unsigned long *) __get_free_page(GFP_KERNEL);
		if (!hvcs_pi_buff) {
		rc = -ENOMEM;
		goto buff_alloc_fail;
		@@ -1548,7 +1548,7 @@ static int __devinit hvcs_initialize(void)
		return 0;

		kthread_fail:
		kfree(hvcs_pi_buff);
		free_page((unsigned long)hvcs_pi_buff);
		buff_alloc_fail:
		tty_unregister_driver(hvcs_tty_driver);
		register_fail:
		@@ -1597,7 +1597,7 @@ static void __exit hvcs_module_exit(void)
		kthread_stop(hvcs_task);

		spin_lock(&hvcs_pi_lock);
		kfree(hvcs_pi_buff);
		free_page((unsigned long)hvcs_pi_buff);
		hvcs_pi_buff = NULL;
		spin_unlock(&hvcs_pi_lock);

Admin message