hwmon: (jz4740) use permission-specific DEVICE_ATTR variants (abf04402) · Commits · 戴 / test

Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source code, improves readbility, and reduces the chance of inconsistencies. The conversion was done automatically using coccinelle. It was validated by compiling both the old and the new source code and comparing its text, data, and bss size. Signed-off-by:

Julia Lawall <Julia.Lawall@lip6.fr> [groeck: Updated description] Signed-off-by:

Guenter Roeck <linux@roeck-us.net>

drivers/hwmon/jz4740-hwmon.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -44,7 +44,7 @@ static irqreturn_t jz4740_hwmon_irq(int irq, void *data)
		return IRQ_HANDLED;
		}

		static ssize_t jz4740_hwmon_read_adcin(struct device *dev,
		static ssize_t in0_input_show(struct device *dev,
		struct device_attribute dev_attr, char buf)
		{
		struct jz4740_hwmon *hwmon = dev_get_drvdata(dev);
		@@ -79,7 +79,7 @@ static ssize_t jz4740_hwmon_read_adcin(struct device *dev,
		return ret;
		}

		static DEVICE_ATTR(in0_input, S_IRUGO, jz4740_hwmon_read_adcin, NULL);
		static DEVICE_ATTR_RO(in0_input);

		static struct attribute *jz4740_attrs[] = {
		&dev_attr_in0_input.attr,

Admin message