Commit abea14bf authored Sep 11, 2020 by Jing Xiangfeng Committed by Boris Brezillon Oct 07, 2020

i3c: master: Fix error return in cdns_i3c_master_probe()



Fix to return negative error code -ENOMEM from the error handling
case instead of 0.

Fixes: 603f2bee ("i3c: master: Add driver for Cadence IP")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://lore.kernel.org/linux-i3c/20200911033350.23904-1-jingxiangfeng@huawei.com

parent cc3a392d

drivers/i3c/master/i3c-master-cdns.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1635,8 +1635,10 @@ static int cdns_i3c_master_probe(struct platform_device *pdev)
		master->ibi.slots = devm_kcalloc(&pdev->dev, master->ibi.num_slots,
		sizeof(*master->ibi.slots),
		GFP_KERNEL);
		if (!master->ibi.slots)
		if (!master->ibi.slots) {
		ret = -ENOMEM;
		goto err_disable_sysclk;
		}

		writel(IBIR_THR(1), master->regs + CMD_IBI_THR_CTRL);
		writel(MST_INT_IBIR_THR, master->regs + MST_IER);

Admin message