Commit abdf5843 authored by Marc Zyngier's avatar Marc Zyngier
Browse files

arm/arm64: KVM: Move vgic handling to a non-preemptible section 



As we're about to introduce some serious GIC-poking to the vgic code,
it is important to make sure that we're going to poke the part of
the GIC that belongs to the CPU we're about to run on (otherwise,
we'd end up with some unexpected interrupts firing)...

Introducing a non-preemptible section in kvm_arch_vcpu_ioctl_run
prevents the problem from occuring.

Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Reviewed-by: default avatarChristoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
parent 9a99d050

arch/arm/kvm/arm.c

+15 −3
Original line number Diff line number Diff line
@@ -523,10 +523,20 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *run) 
		if (vcpu->arch.pause)

			vcpu_pause(vcpu);



		/*

		 * Disarming the background timer must be done in a

		 * preemptible context, as this call may sleep.

		 */

		kvm_timer_flush_hwstate(vcpu);

		kvm_vgic_flush_hwstate(vcpu);



		/*

		 * Preparing the interrupts to be injected also

		 * involves poking the GIC, which must be done in a

		 * non-preemptible context.

		 */

		preempt_disable();

		kvm_vgic_flush_hwstate(vcpu);



		local_irq_disable();



		/*
@@ -539,8 +549,8 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *run) 


		if (ret <= 0 || need_new_vmid_gen(vcpu->kvm)) {

			local_irq_enable();

			preempt_enable();

			kvm_vgic_sync_hwstate(vcpu);

			preempt_enable();

			kvm_timer_sync_hwstate(vcpu);

			continue;

		}
@@ -585,9 +595,11 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *run) 
		 */

		kvm_guest_exit();

		trace_kvm_exit(kvm_vcpu_trap_get_class(vcpu), *vcpu_pc(vcpu));

		preempt_enable();



		kvm_vgic_sync_hwstate(vcpu);



		preempt_enable();



		kvm_timer_sync_hwstate(vcpu);



		ret = handle_exit(vcpu, run, ret);

CRA Git | Maintained and supported by SUSTech CRA and CCSE