Commit abc006b7 authored Jun 25, 2018 by Alex Elder Committed by Andy Gross Sep 13, 2018

soc: qcom: smem: require order of host ids to match



In qcom_smem_enumerate_partitions(), we find all partitions that
have a given local host id in either its host0 or its host1 field
in the partition table entry.  We then verify that the header
structure at the start of each partition also contains the same two
host ids as is found in the table of contents.

There is no requirement that the order of the two host ids be the
same in the table of contents and in the partition header.

This patch changes that, requiring host0 to in the partition table
entry to equal host0 in the partition header structure (and similar
for the host1 values).

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>

parent 06ada44a

drivers/soc/qcom/smem.c

+2 −8

Original line number	Diff line number	Diff line
		@@ -848,15 +848,9 @@ static int qcom_smem_enumerate_partitions(struct qcom_smem *smem,
		return -EINVAL;
		}

		if (host0 != local_host && host1 != local_host) {
		if (host0 != host0 \|\| host1 != host1) {
		dev_err(smem->dev,
		"Partition %d hosts are invalid\n", i);
		return -EINVAL;
		}

		if (host0 != remote_host && host1 != remote_host) {
		dev_err(smem->dev,
		"Partition %d hosts are invalid\n", i);
		"Partition %d hosts don't match\n", i);
		return -EINVAL;
		}

Admin message