Commit aba1e632 authored Aug 21, 2018 by Colin Ian King Committed by Luca Coelho Jan 25, 2019

iwlwifi: pcie: make array 'prop' static, shrinks object size



Don't populate the array prop on the stack but instead make it static.
Makes the object code smaller by 30 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
  80138	  15382	    576	  96096	  17760	drivers/net/wireless/intel/iwlwifi/pcie/trans.o

After:
   text	   data	    bss	    dec	    hex	filename
  79948	  15542	    576	  96066	  17742	drivers/net/wireless/intel/iwlwifi/pcie/trans.o

(gcc version 8.2.0 x86_64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

parent 4ad0be16

drivers/net/wireless/intel/iwlwifi/pcie/trans.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1968,7 +1968,7 @@ static void iwl_trans_pcie_removal_wk(struct work_struct *wk)
		struct iwl_trans_pcie_removal *removal =
		container_of(wk, struct iwl_trans_pcie_removal, work);
		struct pci_dev *pdev = removal->pdev;
		char *prop[] = {"EVENT=INACCESSIBLE", NULL};
		static char *prop[] = {"EVENT=INACCESSIBLE", NULL};

		dev_err(&pdev->dev, "Device gone - attempting removal\n");
		kobject_uevent_env(&pdev->dev.kobj, KOBJ_CHANGE, prop);

Admin message