usb: gadget: s3c-hsotg: fix "protocol stall" handling (ab93e014) · Commits · 戴 / test

After normal handling of SetupDone interrupt, XferCompl interrupt occurs, and then we enqueue new setup request. But when ep0 is stalled, there is no XferCompl, so we have to enqueue setup request immediately after stalling ep. Otherwise incoming control requests won't be processed correctly. Signed-off-by:

Robert Baldyga <r.baldyga@samsung.com> Signed-off-by:

Kyungmin Park <kyungmin.park@samsung.com> Signed-off-by:

Felipe Balbi <balbi@ti.com>

drivers/usb/gadget/s3c-hsotg.c

+8 −2

Original line number	Diff line number	Diff line
		@@ -1164,6 +1164,8 @@ static int s3c_hsotg_process_req_feature(struct s3c_hsotg *hsotg,
		return 1;
		}

		static void s3c_hsotg_enqueue_setup(struct s3c_hsotg *hsotg);

		/**
		* s3c_hsotg_process_control - process a control request
		* @hsotg: The device state
		@@ -1263,11 +1265,15 @@ static void s3c_hsotg_process_control(struct s3c_hsotg *hsotg,
		* don't believe we need to anything more to get the EP
		* to reply with a STALL packet
		*/

		/*
		* complete won't be called, so we enqueue
		* setup request here
		*/
		s3c_hsotg_enqueue_setup(hsotg);
		}
		}

		static void s3c_hsotg_enqueue_setup(struct s3c_hsotg *hsotg);

		/**
		* s3c_hsotg_complete_setup - completion of a setup transfer
		* @ep: The endpoint the request was on.

Admin message