Commit ab7c1e16 authored Apr 15, 2020 by Takashi Iwai Committed by Greg Kroah-Hartman Apr 17, 2020

firmware: Drop unused pages field from struct firmware



The struct firmware contains a page table pointer that was used only
internally in the past.  Since the actual page tables are referred
from struct fw_priv and should be never from struct firmware, we can
drop this unused field gracefully.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Link: https://lore.kernel.org/r/20200415164500.28749-1-tiwai@suse.de


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8f3d9f35

drivers/base/firmware_loader/main.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -548,9 +548,6 @@ static void firmware_free_data(const struct firmware *fw)
		static void fw_set_page_data(struct fw_priv fw_priv, struct firmware fw)
		{
		fw->priv = fw_priv;
		#ifdef CONFIG_FW_LOADER_USER_HELPER
		fw->pages = fw_priv->pages;
		#endif
		fw->size = fw_priv->size;
		fw->data = fw_priv->data;

include/linux/firmware.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -12,7 +12,6 @@
		struct firmware {
		size_t size;
		const u8 *data;
		struct page **pages;

		/* firmware loader private fields */
		void *priv;

Admin message