Commit ab785cfa authored May 14, 2020 by Joerg Roedel

iommu/sun50i: Fix compile warnings



A few compile warnings show up when building this driver:

  CC      drivers/iommu/sun50i-iommu.o
drivers/iommu/sun50i-iommu.c: In function ‘sun50i_dte_get_page_table’:
drivers/iommu/sun50i-iommu.c:486:16: warning: unused variable ‘flags’ [-Wunused-variable]
  486 |  unsigned long flags;
      |                ^~~~~
drivers/iommu/sun50i-iommu.c: In function ‘sun50i_iommu_unmap’:
drivers/iommu/sun50i-iommu.c:559:23: warning: unused variable ‘iommu’ [-Wunused-variable]
  559 |  struct sun50i_iommu *iommu = sun50i_domain->iommu;
      |                       ^~~~~
drivers/iommu/sun50i-iommu.c: In function ‘sun50i_iommu_probe_device’:
drivers/iommu/sun50i-iommu.c:749:22: warning: unused variable ‘group’ [-Wunused-variable]
  749 |  struct iommu_group *group;
      |                      ^~~~~

Remove the unused variables.

Signed-off-by: Joerg Roedel <jroedel@suse.de>
Cc: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20200514124621.25999-1-joro@8bytes.org

parent 4100b8c2

drivers/iommu/sun50i-iommu.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -483,7 +483,6 @@ static u32 sun50i_dte_get_page_table(struct sun50i_iommu_domain sun50i_domain,
		dma_addr_t iova, gfp_t gfp)
		{
		struct sun50i_iommu *iommu = sun50i_domain->iommu;
		unsigned long flags;
		u32 *page_table;
		u32 *dte_addr;
		u32 old_dte;
		@@ -556,7 +555,6 @@ static size_t sun50i_iommu_unmap(struct iommu_domain *domain, unsigned long iova
		size_t size, struct iommu_iotlb_gather *gather)
		{
		struct sun50i_iommu_domain *sun50i_domain = to_sun50i_domain(domain);
		struct sun50i_iommu *iommu = sun50i_domain->iommu;
		phys_addr_t pt_phys;
		dma_addr_t pte_dma;
		u32 *pte_addr;
		@@ -746,7 +744,6 @@ static int sun50i_iommu_attach_device(struct iommu_domain *domain,
		static struct iommu_device sun50i_iommu_probe_device(struct device dev)
		{
		struct sun50i_iommu *iommu;
		struct iommu_group *group;

		iommu = sun50i_iommu_from_dev(dev);
		if (!iommu)

Admin message