Commit ab76228a authored Jun 26, 2014 by Deng-Cheng Zhu Committed by Paolo Bonzini Jun 30, 2014

MIPS: KVM: Remove dead code of TLB index error in kvm_mips_emul_tlbwr()



It's impossible to fall into the error handling of the TLB index after
being masked by (KVM_MIPS_GUEST_TLB_SIZE - 1). Remove the dead code.

Reported-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent db2fb7f2

arch/mips/kvm/emulate.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -846,11 +846,6 @@ enum emulation_result kvm_mips_emul_tlbwr(struct kvm_vcpu *vcpu)
		get_random_bytes(&index, sizeof(index));
		index &= (KVM_MIPS_GUEST_TLB_SIZE - 1);

		if (index < 0 \|\| index >= KVM_MIPS_GUEST_TLB_SIZE) {
		kvm_err("%s: illegal index: %d\n", __func__, index);
		return EMULATE_FAIL;
		}

		tlb = &vcpu->arch.guest_tlb[index];

		/*

Admin message