quota: Fix possible GPF due to uninitialised pointers (ab73ef46) · Commits · 戴 / test

When dqget() in __dquot_initialize() fails e.g. due to IO error, __dquot_initialize() will pass an array of uninitialized pointers to dqput_all() and thus can lead to deference of random data. Fix the problem by properly initializing the array. CC: stable@vger.kernel.org Signed-off-by:

Nikolay Borisov <kernel@kyup.com> Signed-off-by:

Jan Kara <jack@suse.cz>

fs/quota/dquot.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1410,7 +1410,7 @@ static int dquot_active(const struct inode *inode)
		static int __dquot_initialize(struct inode *inode, int type)
		{
		int cnt, init_needed = 0;
		struct dquot *dquots, got[MAXQUOTAS];
		struct dquot *dquots, got[MAXQUOTAS] = {};
		struct super_block *sb = inode->i_sb;
		qsize_t rsv;
		int ret = 0;
		@@ -1427,7 +1427,6 @@ static int __dquot_initialize(struct inode *inode, int type)
		int rc;
		struct dquot *dquot;

		got[cnt] = NULL;
		if (type != -1 && cnt != type)
		continue;
		/*

Admin message