Commit ab6e4e9d authored Dec 08, 2020 by Felix Kuehling Committed by Alex Deucher Dec 09, 2020

drm/amdkfd: Fix leak in dmabuf import



Release dmabuf reference before returning from kfd_ioctl_import_dmabuf.
amdgpu_amdkfd_gpuvm_import_dmabuf takes a reference to the underlying
GEM BO and doesn't keep the reference to the dmabuf wrapper.

Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: Kent Russell <kent.russell@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 6896887b

drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1736,6 +1736,7 @@ static int kfd_ioctl_import_dmabuf(struct file *filep,
		}

		mutex_unlock(&p->mutex);
		dma_buf_put(dmabuf);

		args->handle = MAKE_HANDLE(args->gpu_id, idr_handle);

		@@ -1745,6 +1746,7 @@ err_free:
		amdgpu_amdkfd_gpuvm_free_memory_of_gpu(dev->kgd, (struct kgd_mem *)mem, NULL);
		err_unlock:
		mutex_unlock(&p->mutex);
		dma_buf_put(dmabuf);
		return r;
		}

Admin message