Commit ab60707f authored Feb 10, 2011 by Jesper Juhl Committed by David S. Miller Feb 13, 2011

USB Network driver infrastructure: Fix leak when usb_autopm_get_interface()...

USB Network driver infrastructure: Fix leak when usb_autopm_get_interface() returns less than zero in kevent().

We'll leak the memory allocated to 'urb' in
drivers/net/usb/usbnet.c:kevent() when we 'goto fail_lowmem' and the 'urb'
variable goes out of scope while still completely unused.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d3337de5

drivers/net/usb/usbnet.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -931,8 +931,10 @@ fail_halt:
		if (urb != NULL) {
		clear_bit (EVENT_RX_MEMORY, &dev->flags);
		status = usb_autopm_get_interface(dev->intf);
		if (status < 0)
		if (status < 0) {
		usb_free_urb(urb);
		goto fail_lowmem;
		}
		if (rx_submit (dev, urb, GFP_KERNEL) == -ENOLINK)
		resched = 0;
		usb_autopm_put_interface(dev->intf);

Admin message