Commit ab310b5e authored Mar 30, 2010 by Jason Wessel Committed by Frederic Weisbecker Apr 01, 2010

x86,kgdb: Always initialize the hw breakpoint attribute

It is required to call hw_breakpoint_init() on an attr before using it
in any other calls.  This fixes the problem where kgdb will sometimes
fail to initialize on x86_64.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: 2.6.33 <stable@kernel.org>
LKML-Reference: <1269975907-27602-1-git-send-email-jason.wessel@windriver.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>

parent e49a5bd3

arch/x86/kernel/kgdb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -618,8 +618,8 @@ int kgdb_arch_init(void)
		* portion of kgdb because this operation requires mutexs to
		* complete.
		*/
		hw_breakpoint_init(&attr);
		attr.bp_addr = (unsigned long)kgdb_arch_init;
		attr.type = PERF_TYPE_BREAKPOINT;
		attr.bp_len = HW_BREAKPOINT_LEN_1;
		attr.bp_type = HW_BREAKPOINT_W;
		attr.disabled = 1;

Admin message