Commit ab232e61 authored Jul 08, 2019 by Jakub Kicinski Committed by David S. Miller Jul 08, 2019

net/tls: add missing prot info init



Turns out TLS_TX in HW offload mode does not initialize tls_prot_info.
Since commit 9cd81988 ("net/tls: use version from prot") we actually
use this field on the datapath.  Luckily we always compare it to TLS 1.3,
and assume 1.2 otherwise. So since zero is not equal to 1.3, everything
worked fine.

Fixes: 9cd81988 ("net/tls: use version from prot")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c3b64911

net/tls/tls_device.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -883,6 +883,8 @@ int tls_set_device_offload(struct sock sk, struct tls_context ctx)
		goto free_offload_ctx;
		}

		prot->version = crypto_info->version;
		prot->cipher_type = crypto_info->cipher_type;
		prot->prepend_size = TLS_HEADER_SIZE + nonce_size;
		prot->tag_size = tag_size;
		prot->overhead_size = prot->prepend_size + prot->tag_size;

Admin message