scsi: scsi_debug: Remove a set-but-not-used variable (ab17241c) · Commits · 戴 / test

This patch avoids that gcc reports the following warning when building with W=1: drivers/scsi/scsi_debug.c:2264:15: warning: variable ?pcontrol? set but not used [-Wunused-but-set-variable] Signed-off-by:

Bart Van Assche <bart.vanassche@wdc.com> Reviewed-by:

Christoph Hellwig <hch@lst.de> Reviewed-by:

Hannes Reinecke <hare@suse.com> Cc: Douglas Gilbert <dgilbert@interlog.com> Cc: Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by:

Martin K. Petersen <martin.petersen@oracle.com>

drivers/scsi/scsi_debug.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -2261,7 +2261,7 @@ static int resp_ie_l_pg(unsigned char * arr)
		static int resp_log_sense(struct scsi_cmnd * scp,
		struct sdebug_dev_info * devip)
		{
		int ppc, sp, pcontrol, pcode, subpcode, alloc_len, len, n;
		int ppc, sp, pcode, subpcode, alloc_len, len, n;
		unsigned char arr[SDEBUG_MAX_LSENSE_SZ];
		unsigned char *cmd = scp->cmnd;

		@@ -2272,7 +2272,6 @@ static int resp_log_sense(struct scsi_cmnd * scp,
		mk_sense_invalid_fld(scp, SDEB_IN_CDB, 1, ppc ? 1 : 0);
		return check_condition_result;
		}
		pcontrol = (cmd[2] & 0xc0) >> 6;
		pcode = cmd[2] & 0x3f;
		subpcode = cmd[3] & 0xff;
		alloc_len = get_unaligned_be16(cmd + 7);

Admin message