Commit ab16bfc7 authored Jun 17, 2015 by Neil Brown Committed by NeilBrown Jun 25, 2015

md: clear Blocked flag on failed devices when array is read-only.



The Blocked flag indicates that a device has failed but that this
fact hasn't been recorded in the metadata yet.  Writes to such
devices cannot be allowed until the metadata has been updated.

On a read-only array, the Blocked flag will never be cleared.
This prevents the device being removed from the array.

If the metadata is being handled by the kernel
(i.e. !mddev->external), then we can be sure that if the array is
switch to writable, then a metadata update will happen and will
record the failure.  So we don't need the flag set.

If metadata is externally managed, it is upto the external manager
to clear the 'blocked' flag.

Reported-by: XiaoNi <xni@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.de>

parent 9a8c0fa8

drivers/md/md.c

+9 −0

Original line number	Original line	Diff line number	Diff line
	@@ -8130,6 +8130,15 @@ void md_check_recovery(struct mddev *mddev)
	int spares = 0;		int spares = 0;

	if (mddev->ro) {		if (mddev->ro) {
			struct md_rdev *rdev;
			if (!mddev->external && mddev->in_sync)
			/* 'Blocked' flag not needed as failed devices
			* will be recorded if array switched to read/write.
			* Leaving it set will prevent the device
			* from being removed.
			*/
			rdev_for_each(rdev, mddev)
			clear_bit(Blocked, &rdev->flags);
	/* On a read-only array we can:		/* On a read-only array we can:
	* - remove failed devices		* - remove failed devices
	* - add already-in_sync devices if the array itself		* - add already-in_sync devices if the array itself

Admin message