net: fec: validate the new settings in fec_enet_set_coalesce() (ab14961d) · Commits · 戴 / test

fec_enet_set_coalesce() validates the previously set params and if they are within range proceeds to apply the new ones. The new ones, however, are not validated. This seems backwards, probably a copy-paste error? Compile tested only. Fixes: ("net: fec: add interrupt coalescence feature support") Signed-off-by:

Jakub Kicinski <kuba@kernel.org> Acked-by:

Fugang Duan <fugang.duan@nxp.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/freescale/fec_main.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -2529,15 +2529,15 @@ fec_enet_set_coalesce(struct net_device ndev, struct ethtool_coalesce ec)
		return -EINVAL;
		}

		cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr);
		cycle = fec_enet_us_to_itr_clock(ndev, ec->rx_coalesce_usecs);
		if (cycle > 0xFFFF) {
		dev_err(dev, "Rx coalesced usec exceed hardware limitation\n");
		return -EINVAL;
		}

		cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr);
		cycle = fec_enet_us_to_itr_clock(ndev, ec->tx_coalesce_usecs);
		if (cycle > 0xFFFF) {
		dev_err(dev, "Rx coalesced usec exceed hardware limitation\n");
		dev_err(dev, "Tx coalesced usec exceed hardware limitation\n");
		return -EINVAL;
		}

Admin message