Commit ab1152dd authored by Al Viro's avatar Al Viro
Browse files

unexport d_alloc_pseudo() 



No modular uses since introducion of alloc_file_pseudo(),
and the only non-modular user not in alloc_file_pseudo()
had actually been wrong - should've been d_alloc_anon().

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent ce285c26

Documentation/filesystems/porting

+5 −0
Original line number Diff line number Diff line
@@ -643,3 +643,8 @@ in your dentry operations instead. 
	DCACHE_RCUACCESS is gone; having an RCU delay on dentry freeing is the

	default.  DCACHE_NORCU opts out, and only d_alloc_pseudo() has any

	business doing so.

--

[mandatory]

	d_alloc_pseudo() is internal-only; uses outside of alloc_file_pseudo() are

	very suspect (and won't work in modules).  Such uses are very likely to

	be misspelled d_alloc_anon().

fs/dcache.c

+3 −1
Original line number Diff line number Diff line
@@ -1742,6 +1742,9 @@ struct dentry *d_alloc_cursor(struct dentry * parent) 
 * never be anyone's children or parents.  Unlike all other

 * dentries, these will not have RCU delay between dropping the

 * last reference and freeing them.

 *

 * The only user is alloc_file_pseudo() and that's what should

 * be considered a public interface.  Don't use directly.

 */

struct dentry *d_alloc_pseudo(struct super_block *sb, const struct qstr *name)

{
@@ -1750,7 +1753,6 @@ struct dentry *d_alloc_pseudo(struct super_block *sb, const struct qstr *name) 
		dentry->d_flags |= DCACHE_NORCU;

	return dentry;

}

EXPORT_SYMBOL(d_alloc_pseudo);



struct dentry *d_alloc_name(struct dentry *parent, const char *name)

{

fs/internal.h

+1 −0
Original line number Diff line number Diff line
@@ -155,6 +155,7 @@ extern struct dentry *__d_alloc(struct super_block *, const struct qstr *); 
extern int d_set_mounted(struct dentry *dentry);

extern long prune_dcache_sb(struct super_block *sb, struct shrink_control *sc);

extern struct dentry *d_alloc_cursor(struct dentry *);

extern struct dentry * d_alloc_pseudo(struct super_block *, const struct qstr *);



/*

 * read_write.c

include/linux/dcache.h

+0 −1
Original line number Diff line number Diff line
@@ -235,7 +235,6 @@ extern void d_set_d_op(struct dentry *dentry, const struct dentry_operations *op 
/* allocate/de-allocate */

extern struct dentry * d_alloc(struct dentry *, const struct qstr *);

extern struct dentry * d_alloc_anon(struct super_block *);

extern struct dentry * d_alloc_pseudo(struct super_block *, const struct qstr *);

extern struct dentry * d_alloc_parallel(struct dentry *, const struct qstr *,

					wait_queue_head_t *);

extern struct dentry * d_splice_alias(struct inode *, struct dentry *);

CRA Git | Maintained and supported by SUSTech CRA and CCSE