Commit aafa88f3 authored Sep 20, 2020 by Julia Lawall Committed by Vinod Koul Oct 05, 2020

dmaengine: sh: drop double zeroing

sg_init_table zeroes its first argument, so the allocation of that argument
doesn't have to.

the semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression x,n,flags;
@@

x =
- kcalloc
+ kmalloc_array
  (n,sizeof(*x),flags)
...
sg_init_table(x,n)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

Link: https://lore.kernel.org/r/1600601186-7420-5-git-send-email-Julia.Lawall@inria.fr


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 028926e4

drivers/dma/sh/shdma-base.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -728,7 +728,7 @@ static struct dma_async_tx_descriptor *shdma_prep_dma_cyclic(
		* Allocate the sg list dynamically as it would consumer too much stack
		* space.
		*/
		sgl = kcalloc(sg_len, sizeof(*sgl), GFP_KERNEL);
		sgl = kmalloc_array(sg_len, sizeof(*sgl), GFP_KERNEL);
		if (!sgl)
		return NULL;

Admin message