Commit aaf2c2fb authored Aug 28, 2017 by Tyler Baicar Committed by Rafael J. Wysocki Sep 27, 2017

ACPI / APEI: clear error status before acknowledging the error



Currently we acknowledge errors before clearing the error status.
This could cause a new error to be populated by firmware in-between
the error acknowledgment and the error status clearing which would
cause the second error's status to be cleared without being handled.
So, clear the error status before acknowledging the errors.

Also, make sure to acknowledge the error if the error status read
fails.

Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
Reviewed-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent e931d0da

drivers/acpi/apei/ghes.c

+9 −7

Original line number	Diff line number	Diff line
		@@ -743,17 +743,19 @@ static int ghes_proc(struct ghes *ghes)
		}
		ghes_do_proc(ghes, ghes->estatus);

		out:
		ghes_clear_estatus(ghes);

		if (rc == -ENOENT)
		return rc;

		/*
		* GHESv2 type HEST entries introduce support for error acknowledgment,
		* so only acknowledge the error if this support is present.
		*/
		if (is_hest_type_generic_v2(ghes)) {
		rc = ghes_ack_error(ghes->generic_v2);
		if (rc)
		return rc;
		}
		out:
		ghes_clear_estatus(ghes);
		if (is_hest_type_generic_v2(ghes))
		return ghes_ack_error(ghes->generic_v2);

		return rc;
		}

Admin message