Commit aadbe812 authored by Felipe F. Tonello's avatar Felipe F. Tonello Committed by Felipe Balbi
Browse files

usb: gadget: remove useless parameter in alloc_ep_req() 



The default_length parameter of alloc_ep_req was not really necessary
and gadget drivers would almost always create an inline function to pass
the same value to len and default_len.

This patch removes that parameter and updates all calls to alloc_ep_req() to
use the new API.

Signed-off-by: default avatarFelipe F. Tonello <eu@felipetonello.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 06281d46

drivers/usb/gadget/function/f_hid.c

+1 −1
Original line number Diff line number Diff line
@@ -365,7 +365,7 @@ static int f_hidg_open(struct inode *inode, struct file *fd) 
static inline struct usb_request *hidg_alloc_ep_req(struct usb_ep *ep,

						    unsigned length)

{

	return alloc_ep_req(ep, length, length);

	return alloc_ep_req(ep, length);

}



static void hidg_set_report_complete(struct usb_ep *ep, struct usb_request *req)

drivers/usb/gadget/function/f_loopback.c

+2 −4
Original line number Diff line number Diff line
@@ -308,9 +308,7 @@ static void disable_loopback(struct f_loopback *loop) 


static inline struct usb_request *lb_alloc_ep_req(struct usb_ep *ep, int len)

{

	struct f_loopback	*loop = ep->driver_data;



	return alloc_ep_req(ep, len, loop->buflen);

	return alloc_ep_req(ep, len);

}



static int alloc_requests(struct usb_composite_dev *cdev,
@@ -333,7 +331,7 @@ static int alloc_requests(struct usb_composite_dev *cdev, 
		if (!in_req)

			goto fail;



		out_req = lb_alloc_ep_req(loop->out_ep, 0);

		out_req = lb_alloc_ep_req(loop->out_ep, loop->buflen);

		if (!out_req)

			goto fail_in;

drivers/usb/gadget/function/f_midi.c

+1 −1
Original line number Diff line number Diff line
@@ -211,7 +211,7 @@ static struct usb_gadget_strings *midi_strings[] = { 
static inline struct usb_request *midi_alloc_ep_req(struct usb_ep *ep,

						    unsigned length)

{

	return alloc_ep_req(ep, length, length);

	return alloc_ep_req(ep, length);

}



static const uint8_t f_midi_cin_length[] = {

drivers/usb/gadget/function/f_sourcesink.c

+2 −4
Original line number Diff line number Diff line
@@ -293,9 +293,7 @@ static struct usb_gadget_strings *sourcesink_strings[] = { 


static inline struct usb_request *ss_alloc_ep_req(struct usb_ep *ep, int len)

{

	struct f_sourcesink		*ss = ep->driver_data;



	return alloc_ep_req(ep, len, ss->buflen);

	return alloc_ep_req(ep, len);

}



static void disable_ep(struct usb_composite_dev *cdev, struct usb_ep *ep)
@@ -606,7 +604,7 @@ static int source_sink_start_ep(struct f_sourcesink *ss, bool is_in, 
	} else {

		ep = is_in ? ss->in_ep : ss->out_ep;

		qlen = ss->bulk_qlen;

		size = 0;

		size = ss->buflen;

	}



	for (i = 0; i < qlen; i++) {

drivers/usb/gadget/u_f.c

+3 −4
Original line number Diff line number Diff line
@@ -14,15 +14,14 @@ 
#include "u_f.h"

#include <linux/usb/ch9.h>



struct usb_request *alloc_ep_req(struct usb_ep *ep, size_t len, int default_len)

struct usb_request *alloc_ep_req(struct usb_ep *ep, size_t len)

{

	struct usb_request      *req;



	req = usb_ep_alloc_request(ep, GFP_ATOMIC);

	if (req) {

		req->length = len ?: default_len;

		if (usb_endpoint_dir_out(ep->desc))

			req->length = usb_ep_align(ep, req->length);

		req->length = usb_endpoint_dir_out(ep->desc) ?

			usb_ep_align(ep, len) : len;

		req->buf = kmalloc(req->length, GFP_ATOMIC);

		if (!req->buf) {

			usb_ep_free_request(ep, req);

CRA Git | Maintained and supported by SUSTech CRA and CCSE