Commit aab38f51 authored Aug 02, 2016 by Joe Perches Committed by Linus Torvalds Aug 02, 2016

checkpatch: yet another commit id improvement

Using \b isn't good enough to isolate what appears to be a commit id in
a commit message.

Make sure there is a space or a quote like character after a continuous
run of hexadecimal characters that could be a commit id.

Link: http://lkml.kernel.org/r/fdd22b47463a21c21132edbb8aa35e372950a1e6.1468869915.git.joe@perches.com


Signed-off-by: Joe Perches <joe@perches.com>
Cc: "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent dadf680d

scripts/checkpatch.pl

+2 −2

Original line number	Diff line number	Diff line
		@@ -2459,9 +2459,9 @@ sub process {

		# Check for git id commit length and improperly formed commit descriptions
		if ($in_commit_log && !$commit_log_possible_stack_dump &&
		$line !~ /^\s*(?:Link\|Patchwork\|http\|BugLink):/i &&
		$line !~ /^\s*(?:Link\|Patchwork\|http\|https\|BugLink):/i &&
		($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i \|\|
		($line =~ /\b[0-9a-f]{12,40}\b/i &&
		($line =~ /(?:\s\|^)[0-9a-f]{12,40}(?:[\s"'\(\[]\|$)/i &&
		$line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&
		$line !~ /\bfixes:\s*[0-9a-f]{12,40}/i))) {
		my $init_char = "c";

Admin message