Commit aaa3cbba authored May 22, 2020 by Qiushi Wu Committed by Enric Balletbo i Serra Jun 30, 2020

platform/chrome: cros_ec_ishtp: Fix a double-unlock issue



In function cros_ec_ishtp_probe(), "up_write" is already called
before function "cros_ec_dev_init". But "up_write" will be called
again after the calling of the function "cros_ec_dev_init" failed.
Thus add a call of the function “down_write” in this if branch
for the completion of the exception handling.

Fixes: 26a14267 ("platform/chrome: Add ChromeOS EC ISHTP driver")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Tested-by: Mathew King <mathewk@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

parent 9a876ba5

drivers/platform/chrome/cros_ec_ishtp.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -681,8 +681,10 @@ static int cros_ec_ishtp_probe(struct ishtp_cl_device *cl_device)

		/* Register croc_ec_dev mfd */
		rv = cros_ec_dev_init(client_data);
		if (rv)
		if (rv) {
		down_write(&init_lock);
		goto end_cros_ec_dev_init_error;
		}

		return 0;

Admin message