Commit aa9d7295 authored Nov 30, 2020 by Minwoo Im Committed by Christoph Hellwig Dec 01, 2020

nvme: improve an error message on Identify failure



Add the namespace ID to the error message when the Identify command used
to retrieve the Namespace Identification Descriptor list fails.

This avoids rather useless and duplicative messages like the following:
[    1.321031] nvme nvme0: Identify Descriptors failed (16386)
[    1.321948] nvme nvme0: Identify Descriptors failed (16386)
[    1.322872] nvme nvme0: Identify Descriptors failed (16386)
[    1.323775] nvme nvme0: Identify Descriptors failed (16386)
[    1.324687] nvme nvme0: Identify Descriptors failed (16386)
...

Also, print the nvme status code in hexadecimal rather than decimal
format rather for better readability.

Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent 8c4dfea9

drivers/nvme/host/core.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1368,7 +1368,8 @@ static int nvme_identify_ns_descs(struct nvme_ctrl *ctrl, unsigned nsid,
		NVME_IDENTIFY_DATA_SIZE);
		if (status) {
		dev_warn(ctrl->device,
		"Identify Descriptors failed (%d)\n", status);
		"Identify Descriptors failed (nsid=%u, status=0x%x)\n",
		nsid, status);
		goto free_data;
		}

Admin message