Commit aa931977 authored Jan 09, 2014 by Alex Williamson Committed by Bjorn Helgaas Jan 10, 2014

PCI: Never treat a VF as a multifunction device

Per the SR-IOV spec rev 1.1:

  3.4.1.9 Header Type (Offset 0Eh)

  "... For VFs, this register must be RO Zero."

Unfortunately some devices get this wrong, ex. Emulex OneConnect 10Gb NIC.
When they do it makes us handle ACS testing and therefore IOMMU groups as
if they were actual multifunction devices and require ACS capabilities to
make sure there's no peer-to-peer between functions.  VFs are never
traditional multifunction devices, so simply clear this bit before we get
any further into setup.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=68431


Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

parent c2a5a829

drivers/pci/iov.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -84,6 +84,7 @@ static int virtfn_add(struct pci_dev *dev, int id, int reset)
		virtfn->dev.parent = dev->dev.parent;
		virtfn->physfn = pci_dev_get(dev);
		virtfn->is_virtfn = 1;
		virtfn->multifunction = 0;

		for (i = 0; i < PCI_SRIOV_NUM_BARS; i++) {
		res = dev->resource + PCI_IOV_RESOURCES + i;

Admin message